Actually use the compile --outputPath option if the user provides one #2432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majcosta
force-pushed
the
pr_use_outputpath
branch
from
7a274ff to
1b22b60
Compare
majcosta
changed the title
It was just not being used, defaulting to the parent of installPath. it still does, if the user does not specify a directory using --outputPath
majcosta
force-pushed
the
pr_use_outputpath
branch
from
1b22b60 to
f2a2ae4
Compare
|
I will test it in the preview branch and see to include it in the changes I have planned to work on today. |
EzioTheDeadPoet
merged commit 2adcf45
into
wabbajack-tools:pr_use_outputpath
1 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was just not being used, defaulting to the parent of installPath. it still does, if the user does not specify a directory using --outputPath